Le 06/11/2016 à 07:18, Richard Henderson a écrit :
...
> + if (is_load) {
> + /* memory to register */
> + for (i = 0; i < 16; i++) {
> + if (mask & (1 << i)) {
> + r[i] = gen_load(s, opsize, addr, 1);
> + tcg_gen_add_i32(addr, addr, incr);
> + }
> + }
> + for (i = 0; i < 16; i++) {
> + if (mask & (1 << i)) {
> + tcg_gen_mov_i32(mreg(i), r[i]);
> + tcg_temp_free(r[i]);
> + }
> + }
> + if (mode == 3) {
> + /* post-increment: movem (An)+,X */
> + tcg_gen_mov_i32(AREG(insn, 0), addr);
Why AREG() instead of cpu_aregs[]?
> + }
> + } else {
> + /* register to memory */
> + if (mode == 4) {
> + /* pre-decrement: movem X,-(An) */
> + for (i = 15; i >= 0; i--) {
> + if ((mask << i) & 0x8000) {
> + tcg_gen_sub_i32(addr, addr, incr);
> + if (reg0 + 8 == i &&
> + m68k_feature(s->env, M68K_FEATURE_EXT_FULL)) {
> + /* M68020+: if the addressing register is the
> + * register moved to memory, the value written
> + * is the initial value decremented by the size of
> + * the operation, regardless of how many actual
> + * stores have been performed until this point.
> + * M68000/M68010: the value is the initial value.
> + */
> + TCGv tmp = tcg_temp_new();
tmp is already declared at the top of the function, perhaps you can
remove the declaration part here?
Thanks,
Laurent
