On Mon, Oct 31, 2016 at 02:45:24PM +0000, Peter Maydell wrote: > On 28 October 2016 at 18:46, Jose Ricardo Ziviani > <jos...@linux.vnet.ibm.com> wrote: > > From: Jose Ricardo Ziviani <jos...@br.ibm.com> > > > > This is an initial effort to have RISU working for PPC64LE. > > > > I also made some changes to isolate risugen, creating two modules > > (risugen_arm.pm and risugen_ppc64le.pm) to implement specific > > instructions in it. > > > > Suggestions are welcome! :) > > > > TODOS: > > - improve load/store instruction generation > > - improve initial random values for FP and Vector regs. > > > > Jose Ricardo Ziviani (3): > > Implementation of ppc64le module for risugen and risufile > > Isolates Arm specific subroutines out from risugen main file > > Initial implemention for ppc64le > > Thanks for this patchset. The modularisation of architecture > support in particular is something we've needed for a while. > > I've made a few first-pass review comments and some suggestions > for breaking up the patchset to make it a bit easier to review. > I'll try to go easy on the review requirements since this is > fundamentally just a test tool. > > Getting the copyright statements right is really important > though -- I can't apply it without those being fixed. > > thanks > -- PMM >
I thank you for reviewing it, really appreciate that. I'll break it up in smaller pieces, apply the suggestions, and send a v2 soon. Thank you! Ziviani
