On 28 October 2016 at 18:46, Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> wrote: > - This commit creates the initial risugen support for ppc64le in a > new module to avoid the mixture of Arm and Power instructions. It > also implements the ppc64le risu file covering all instruction from > PowerISA - v3.0 book I. > > Signed-off-by: Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> > --- > ppc64le.risu | 3459 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > risugen_ppc64le.pm | 460 +++++++ > 2 files changed, 3919 insertions(+) > create mode 100644 ppc64le.risu > create mode 100644 risugen_ppc64le.pm > > diff --git a/ppc64le.risu b/ppc64le.risu > new file mode 100644 > index 0000000..08ed6fc > --- /dev/null > +++ b/ppc64le.risu > @@ -0,0 +1,3459 @@ > +############################################################################### > +# Copyright (c) 2016 Linaro Limited
This doesn't look like the right copyright line :-) Also, four thousand line patch emails are completely impossible for me to review -- can you split it up a bit, please? (In particular please don't put the risugen changes in the same file as the .risu file). I was surprised to see this patch at this point in the patch series -- surely you want to first add support to the core risugen code for having per-target-cpu modules, and then have a patch adding support for a ppc module? thanks -- PMM
