On 10/10/2016 12:03 PM, Max Reitz wrote: >> I'm not sure what the right way would be to get this information out >> (...maybe make it optional and set it only if qtest_enabled() is true?), >> but in my opinion this is not the right way. > > By the way, the cleanest way I can come up with (which I didn't write > about in my first reply because it's not so trivial) would be some kind > of debugging QMP command convention. For instance, we could say that all > debugging commands have an x-debug- prefix, and then you could add an > x-debug-get-bitmap-md5 to read the MD5 hash of a named bitmap. That > would appear to be the cleanest way to do this to me.
Anything named x- is automatically not stable, and therefore free to use in the testsuite without having to worry about keeping it backwards compatible (libvirt won't touch x- commands). The suggestion of x-debug- to mark it as specifically for debug use is reasonable. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
