On Thu, Sep 22, 2016 at 01:18:24PM +0200, Andrew Jones wrote: > On Thu, Sep 22, 2016 at 02:15:08PM +0800, Peter Xu wrote: > > pci-testdev is used mostly in kvm-unit-test for some eventfd tests. > > However I see it a good framework for other tests as well (e.g., the > > IOMMU unit test in the future). So enhanced it to support more > > testcases. > > > > The original memory handlers and protocol are strict and not easy to > > change (we need to keep the old behavior of pci-testdev). So I added a > > new parameter for the device, and memory ops will be dynamically handled > > depending on what testcase it is configured. To specify a new test case > > for pci-testdev, we use: > > > > -device pci-testdev,testcase=XXX > > > > The default will be "eventfd", which is the original behavior for > > pci-testdev. In the future, we can just add new testcase for pci-testdev > > to achieve different goals. > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > --- > > > > This is kind-of a RFC since I am not sure whether this is a good way. > > I'm not either :-) I haven't looked too closely at this test device, > but I have been involved in reviewing a kvm-unit-tests series[*] that > will drive it. Please take a look at that series and maybe test with > it as well. > > Thanks, > drew > > [*] https://www.spinics.net/lists/kvm/msg136892.html
Cool! Will go over. Thanks for the link. :-) -- peterx
