Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474481984-10452-1-git-send-email-ro...@mellanox.com
Subject: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in
Libiscsi-QEMU
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1474481984-10452-1-git-send-email-ro...@mellanox.com ->
patchew/1474481984-10452-1-git-send-email-ro...@mellanox.com
Switched to a new branch 'test'
6a9d88e block/iscsi: Adding iser support in Libiscsi-QEMU
=== OUTPUT BEGIN ===
Checking PATCH 1/1: block/iscsi: Adding iser support in Libiscsi-QEMU...
WARNING: line over 80 characters
#48: FILE: block/iscsi.c:601:
+ NULL, num_sectors *
iscsilun->block_size,
WARNING: line over 80 characters
#49: FILE: block/iscsi.c:602:
+ iscsilun->block_size, 0, 0, fua,
0, 0,
ERROR: line over 90 characters
#50: FILE: block/iscsi.c:603:
+ iscsi_co_generic_cb, &iTask,
(struct scsi_iovec *)iov->iov, iov->niov);
WARNING: line over 80 characters
#53: FILE: block/iscsi.c:606:
+ NULL, num_sectors *
iscsilun->block_size,
WARNING: line over 80 characters
#54: FILE: block/iscsi.c:607:
+ iscsilun->block_size, 0, 0, fua,
0, 0,
ERROR: line over 90 characters
#55: FILE: block/iscsi.c:608:
+ iscsi_co_generic_cb, &iTask,
(struct scsi_iovec *)iov->iov, iov->niov);
ERROR: line over 90 characters
#84: FILE: block/iscsi.c:815:
+ iscsi_co_generic_cb, &iTask,
(struct scsi_iovec *)iov->iov, iov->niov);
ERROR: line over 90 characters
#90: FILE: block/iscsi.c:821:
+ iscsi_co_generic_cb, &iTask,
(struct scsi_iovec *)iov->iov, iov->niov);
WARNING: line over 80 characters
#116: FILE: block/iscsi.c:1626:
+ iscsi_url = iscsi_parse_full_url(iscsi, uri_string_unescape(filename, -1,
NULL));
ERROR: line over 90 characters
#119: FILE: block/iscsi.c:1628:
+ error_setg(errp, "Failed to parse URL : %s",
uri_string_unescape(filename, -1, NULL));
ERROR: architecture specific defines should be avoided
#168: FILE: block/iscsi.c:2076:
+#ifdef __linux__
total: 6 errors, 5 warnings, 144 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
