On Wed, Sep 14, 2016 at 09:56:47PM +0200, Thomas Huth wrote: > On 14.09.2016 20:48, Laurent Vivier wrote: > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > > --- > > hw/scsi/spapr_vscsi.c | 89 > > +++++++++++++++++++++------------------------------ > > hw/scsi/trace-events | 27 ++++++++++++++++ > > 2 files changed, 63 insertions(+), 53 deletions(-) > > > > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > > index 8fbd50f..29fef90 100644 > > --- a/hw/scsi/spapr_vscsi.c > > +++ b/hw/scsi/spapr_vscsi.c > > While you're at it: There is a stray fprintf statement at the beginning > of vscsi_process_tsk_mgmt() which is rather a debug statement than > really something that should be printed always ... could you please turn > that into a trace event, too?
That would be a good idea, but I'd prefer to see it as a follow up patch.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
