On 09/14/2016 01:48 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
> ---
> hw/ppc/spapr_drc.c | 54
> ++++++++++++++++++++---------------------------------
> hw/ppc/trace-events | 22 ++++++++++++++++++++++
> 2 files changed, 42 insertions(+), 34 deletions(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index 4b1a943..6e54fd4 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -20,20 +20,7 @@
> #include "qapi/visitor.h"
> #include "qemu/error-report.h"
> #include "hw/ppc/spapr.h" /* for RTAS return codes */
> -
> -/* #define DEBUG_SPAPR_DRC */
> -
> -#ifdef DEBUG_SPAPR_DRC
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> -#define DPRINTFN(fmt, ...) \
> - do { DPRINTF(fmt, ## __VA_ARGS__); fprintf(stderr, "\n"); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)Yay - you're also getting rid of bit-rotting format strings! > +++ b/hw/ppc/trace-events > @@ -35,6 +35,28 @@ spapr_iommu_ddw_create(uint64_t buid, uint32_t cfgaddr, > uint64_t pg_size, uint64 > spapr_iommu_ddw_remove(uint32_t liobn) "liobn=%"PRIx32 > spapr_iommu_ddw_reset(uint64_t buid, uint32_t cfgaddr) "buid=%"PRIx64" > addr=%"PRIx32 > > +# hw/ppc/spapr_drc.c > + > +spapr_drc_set_isolation_state(uint32_t index, int state) "drc: 0x%"PRIx32", > state: %"PRIx32 Most trace files don't have a line between the comment and first relevant function... > # hw/ppc/ppc.c > ppc_tb_adjust(uint64_t offs1, uint64_t offs2, int64_t diff, int64_t seconds) > "adjusted from 0x%"PRIx64" to 0x%"PRIx64", diff %"PRId64" (%"PRId64"s)" > like this. With that fixed, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
