On Fri, 26 Aug 2016 18:05:31 +0200 Cédric Le Goater <c...@kaod.org> wrote:
> When issuing a chassis 'powerdown' control command, the routine > qemu_system_shutdown_request() should be used to exit the guest. > qemu_system_powerdown_request() will initiate a soft shutdown which is > not what is required by the IPMI (28.3 Chassis Control Command): > > 0h = power down. Force system into soft off (S4/S45) state. This > is for 'emergency' management power down actions. The command does > not initiate a clean shut-down of the operating system prior to > powering down the system > > Signed-off-by: Cédric Le Goater <c...@kaod.org> > --- > FWIW this had been suggested during the review: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03304.html Acked-by: Greg Kurz <gr...@kaod.org> > We could use qemu_system_powerdown_request() under > IPMI_SHUTDOWN_VIA_ACPI_OVERTEMP which is what is expected I think. > 5h = Initiate a soft-shutdown of OS via ACPI by emulating a fatal overtemperature. (optional) This looks appropriate indeed. > hw/ipmi/ipmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c > index f09f217e7835..f91c7b74ca38 100644 > --- a/hw/ipmi/ipmi.c > +++ b/hw/ipmi/ipmi.c > @@ -51,7 +51,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op, > int checkonly) > if (checkonly) { > return 0; > } > - qemu_system_powerdown_request(); > + qemu_system_shutdown_request(); > return 0; > > case IPMI_SEND_NMI:
