Re: [Qemu-devel] [PATCH 2/6] target-ppc: Implement darn instruction

[Benjamin Herrenschmidt]

On Sun, 2016-08-07 at 23:06 +0530, Nikunj A Dadhania wrote:
> +target_ulong helper_darn(uint32_t l)
> +{
> +    target_ulong r = UINT64_MAX;
> +
> +    if (l <= 2) {
> +        do {
> +            r = random() * random();
> +            r &= l ? UINT64_MAX : UINT32_MAX;
> +        } while (r == UINT64_MAX);
> +    }
> +
> +    return r;
> +}
>  #endif

Isn't this a bit week ? Look at the implementation of H_RANDOM...

Cheers,
Ben.