On 03.08.2016 13:21, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-mirror to accept a node-name without lifting the restriction that > we're operating at a root node. > > In case of an invalid device name, the command returns the GenericError > error class now instead of DeviceNotFound, because this is what > qmp_get_root_bs() returns. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > blockdev.c | 14 +++----------- > qapi/block-core.json | 5 +++-- > qmp-commands.hx | 3 ++- > tests/qemu-iotests/041 | 8 +++----- > 4 files changed, 11 insertions(+), 19 deletions(-)
[...] > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 6b89b36..22bdb41 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1689,7 +1689,8 @@ Arguments: > > - "job-id": Identifier for the newly-created block job. If omitted, > the device name will be used. (json-string, optional) > -- "device": device name to operate on (json-string) > +- "device": the device name or node-name of a root node whose writes should > be > + mirrored.(json-string) Critical issue spotted in the last minute: Space missing after the period! (Or there should probably not be a period at all, considering that the "sentence" is not really one and that it starts with a lower letter.) Max > - "target": name of new image file (json-string) > - "format": format of new image (json-string, optional) > - "node-name": the name of the new block driver state in the node graph
signature.asc
Description: OpenPGP digital signature
