Hi

On Tue, Aug 2, 2016 at 11:53 PM Paolo Bonzini <pbonz...@redhat.com> wrote:

> From: "Emilio G. Cota" <c...@braap.org>
>
> In qdist_bin__internal(), to->entries is initialized to a 1-element array,
> which we then leak when n == from->n. Fix it.
>
> Signed-off-by: Emilio G. Cota <c...@braap.org>
> Message-Id: <1469459025-23606-2-git-send-email-c...@braap.org>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
>  util/qdist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qdist.c b/util/qdist.c
> index 56f5738..eb2236c 100644
> --- a/util/qdist.c
> +++ b/util/qdist.c
> @@ -188,7 +188,7 @@ void qdist_bin__internal(struct qdist *to, const
> struct qdist *from, size_t n)
>              }
>          }
>          /* they're equally spaced, so copy the dist and bail out */
> -        to->entries = g_new(struct qdist_entry, from->n);
> +        to->entries = g_realloc_n(to->entries, n, sizeof(*to->entries));
>

I sent that patch earlier in the leak series, if it's still time, please:

Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>




>          to->n = from->n;
>          memcpy(to->entries, from->entries, sizeof(*to->entries) * to->n);
>          return;
> --
> 2.7.4
>
>
>
>

Reply via email to