On 07/28/2016 01:07 AM, Prerna Saxena wrote: > From: Prerna Saxena <prerna.sax...@nutanix.com> > > This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK. >
> + > +With this protocol extension negotiated, the sender (QEMU) can set the > +"need_reply" [Bit 3] flag to any command. This indicates that > +the client MUST respond with a Payload VhostUserMsg indicating success or > +failure. The payload should be set to zero on success or non-zero on failure. > +(Unless the message already has an explicit reply body) Rather than make this parenthetical, I would go with: The payload should be set to zero on success or non-zero on failure, unless the message already has an explicit reply body. > + > +This indicates to QEMU that the requested operation has deterministically > +been met or not. Today, QEMU is expected to terminate the main vhost-user Reads awkwardly; maybe: The response payload gives QEMU a deterministic indication of the result of the command. > +loop upon receiving such errors. In future, qemu could be taught to be more > +resilient for selective requests. > + > +For the message types that already solicit a reply from the client, the > +presence of VHOST_USER_PROTOCOL_F_REPLY_ACK or need_reply bit being set > brings > +no behaviourial change. (See the 'Communication' section for details.) s/behaviourial/behavioural/ (or if the document widely favors US spelling, behavioral) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
