On Fri, 2016-07-29 at 14:40 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-07-29 at 13:34 +1000, David Gibson wrote: > > > > > > What should I do with this in the short term? Leave it in > > ppc-for-2.8, or remove it for now pending possible changes? > > I think I'm still measuring a performance improvement with this, I'll > test a bit more and will get back to you. > > It will definitely better to do it without a helper once Richard's 128- > bit stuff is in.
Ok, after I nice'd myself on top of all the gcc's on that test machine I confirm that this patch is a loss on qemu-user. It might still be a win for qemu-system-ppc64 due to the translation but probably not worth bothering. So drop this one. I'll use the 128-bit support when it becomes available. Cheers, Ben.