On 19/07/2016 17:28, Eric Blake wrote: >> If I'm reading the NBD proto.md correctly, this is not enough if >> NBD_CMD_FLAG_NO_HOLE is specified. We probably need to use a zeroed buffer >> with >> blk_pwrite, or pass a new flag (BDRV_RED_NO_HOLE) to blk_pwrite_zeroes to >> enforce the bdrv_driver_pwritev() branch in bdrv_co_do_pwrite_zeroes().
I agree with Eric's interpretation. It's a bit weird to have the direction inverted, but I'm not sure I see the ambiguity. Can you explain? Paolo
signature.asc
Description: OpenPGP digital signature
