On Thu, 07/07 11:18, Cao jin wrote: > > > On 07/07/2016 08:31 AM, Fam Zheng wrote: > > On Wed, 07/06 15:46, Cao jin wrote: > > > > > > > Yes, but in this patch I think the blank line changes are 1) more of > > personal > > taste, 2) completely unrelated (neither lines nor semantics) to the > > functional > > change. > > > > Fam > > Indeed, my personal taste. Generally speaking, well separated code block is > easier for newbies to read. This is what I has been trained before, and I > like it, so I just can't help to add these lines when the code in my hand:P > BTW, I am curious about maintainer`s opinion about this thing:)
It of course doesn't hurt git blame, as far as I can tell. Please Cc qemu-trivial in the separate patch. Fam