On Wed, 07/06 11:03, Cao jin wrote:
> pointer 'qemu_aio_context' should be checked first before it is used.
> qemu_bh_new() will use it.
>
> Also add extra newlines to make code well separated and easier to read.
This "also" is not good, please only do one thing in a patch.
Fam
>
> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com>
> ---
> main-loop.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/main-loop.c b/main-loop.c
> index 89a6994..0d943f1 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -154,18 +154,23 @@ int qemu_init_main_loop(Error **errp)
> }
>
> qemu_aio_context = aio_context_new(&local_error);
> - qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
> if (!qemu_aio_context) {
> error_propagate(errp, local_error);
> return -EMFILE;
> }
> +
> + qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
> +
> gpollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD));
> +
> src = aio_get_g_source(qemu_aio_context);
> g_source_attach(src, NULL);
> g_source_unref(src);
> +
> src = iohandler_get_g_source();
> g_source_attach(src, NULL);
> g_source_unref(src);
> +
> return 0;
> }
>
> --
> 2.1.0
>
>
>
>
