On Tue 05 Jul 2016 10:45:21 AM CEST, Daniel P. Berrange wrote: > The point of using qcrypto_hash_supports() is that it isolates the > block code Makefile rules from the details of the current specific > impl of the hash APIs in QEMU. As a prime example of why this is > important, try rebasing to GIT master, and you'll find we no longer > use gnutls for the hash APIs. We choose between libgcrypt, nettle or a > empty stub for hash impls now. I think it is a backwards step to add > back these makefile conditionals
Now that you mention this I wonder why we are not using glib for the hashing functions. GChecksum is available since glib 2.16 (QEMU requires 2.22) and it supports MD5, SHA1, SHA256 and SHA512. I see that in git master there's now a few algorithms more, but for the Quorum case those ones are enough. Berto
