On Tue, 07/05 09:58, Sascha Silbe wrote:
> Dear Fam (or Zheng?),
Hi Sascha,
Zheng is the last name here. :)
>
> Fam Zheng <f...@redhat.com> writes:
>
> > This was the only exceptional module init function that does something
> > else than a simple list of bdrv_register() calls, in all the block
> > drivers.
> >
> > The qcrypto_hash_supports is actually a static check, determined at
> > compile time. Follow the block-job-$(CONFIG_FOO) convention for
> > consistency.
>
> Good idea.
>
>
> [block/Makefile.objs]
> > @@ -3,7 +3,7 @@ block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o
> > qcow2-snapshot.o qcow2-c
> > block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o
> > block-obj-y += qed-check.o
> > block-obj-$(CONFIG_VHDX) += vhdx.o vhdx-endian.o vhdx-log.o
> > -block-obj-y += quorum.o
> > +block-obj-$(CONFIG_GNUTLS_HASH) += quorum.o
> [...]
> [block/quorum.c]
> > static void bdrv_quorum_init(void)
> > {
> > - if (!qcrypto_hash_supports(QCRYPTO_HASH_ALG_SHA256)) {
> > - /* SHA256 hash support is required for quorum device */
> > - return;
> > - }
> > bdrv_register(&bdrv_quorum);
>
> The quorum driver needs SHA256 which was introduced in gnutls
> 2.11.1. However configure sets CONFIG_GNUTLS_HASH when gnutls 2.9.10+ is
> present. You should either bump the version in configure or add an
> explicit configure check for SHA256.
Yes, I just noticed commit 0c16c056a4f removed CONFIG_GNUTLS_HASH so I need to
rebase anyway (that commit also fixed this version requirement we have been
missing as you mentioned). Thanks for reviewing!
Fam
