On 06/23/2016 11:21 AM, Sergey Sorokin wrote:
Yes, I thought about it. tcg_canonicalize_memop() is good place too.
But do you think that get_alignment_bits() is not good enough?
I think the earlier a target-* translator problem is diagnosed the better.
Leaving things in get_alignment_bits is ok, so long as we then invoke
get_alignment bits in tcg_canonicalize_memop. Perhaps
static inline TCGMemOp tcg_canonicalize_memop(TCGMemOp op, bool is64, bool st)
{
/* Trigger the asserts within sooner rather than later. */
(void)get_alignment_bits(op);
...
}
r~
