Yes, I thought about it. tcg_canonicalize_memop() is good place too. But do you think that get_alignment_bits() is not good enough?
23.06.2016, 19:13, "Richard Henderson" <r...@twiddle.net>: > On 06/23/2016 07:13 AM, Sergey Sorokin wrote: >>> I think we ought to check this in tcg-op.c, rather than wait until >>> generating >>> code in the backend. >> I think it's better to check this in one place in get_alignment_bits() >> function >> because there can be a direct call of helpers from softmmu_template.h. > > I'm talking about the asserts in tcg/*/tcg-target.inc.c. Those asserts are > better done in once place in tcg_canonicalize_memop. > > r~