On 21/06/2016 13:53, Peter Maydell wrote: >>> >> object_property_add_child(object_get_root(), "machine", >>> >> OBJECT(current_machine), &error_abort); >>> >> + >>> >> + init_l1_page_table_param(); >> > >> > Please call this from cpu_exec_init_all instead. > If you're going to call it that early (ie before machine init) > than I think we might as well just call it from the existing > page_init() function in translate-all.c instead, right? > (gets called when the tcg accelerator is inited; we don't need > to set up the l1 map if we're not using TCG).
Yes, good idea. Paolo