On 13 June 2016 at 10:43, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 13 June 2016 at 10:08, <vija...@caviumnetworks.com> wrote: >> +/* >> + * Holds TARGET_AARCH_64_PAGE_BITS or TARGET_ARM_PAGE_BITS >> + * based on the the cpu type emulated at runtime. >> + */ >> +static uint32_t target_page_bits; > > The CPU page size is not specific to the 'virt' board, so this > is the wrong place to do this. You should identify the > page size in arm_cpu_realizefn() based on the set of feature > bits the CPU has: anything with ARM_FEATURE_V7 has a 4K page > table (this includes a lot of 32-bit CPUs).
Actually that should be "with ARM_FEATURE_V7 and not ARM_FEATURE_MPU", or we'll break the PMSA code. Note that you'll also need to handle systems where the different CPUs in it disagree about the preferred target page size -- the xlnx-ep108 board can have both Cortex-A53 (prefers 4K) and Cortex-R5 (prefers 1K) CPUs in it. "Use the smallest value required by any CPU on the board" is probably the best approach. thanks -- PMM
