On Thu, 16 Jun 2016 13:49:38 +0200 Thomas Huth <th...@redhat.com> wrote:
> On 16.06.2016 05:49, Bharata B Rao wrote: > > On Wed, Jun 15, 2016 at 04:04:14PM +1000, David Gibson wrote: > >> On Fri, Jun 10, 2016 at 03:14:14PM +1000, David Gibson wrote: > >>> On Fri, Jun 10, 2016 at 06:28:59AM +0530, Bharata B Rao wrote: > >>>> Hi, > >>>> > >>>> This is the next version of the CPU hotplug patchset for PowerPC > >>>> sPAPR target. The hotplug semantics looks like this: > >>>> > >>>> (qemu) device_add POWER8E-spapr-cpu-core,id=core2,core-id=16[,threads=4] > >>>> (qemu) device_add host-spapr-cpu-core,id=core2,core-id=16[,threads=4] > >>>> (qemu) device_add > >>>> POWER8E_v2.1-spapr-cpu-core,id=core2,core-id=16[,threads=4] > >>> > >>> I've merged these to my ppc-cpu-hotplug branch, and I'm doing some > >>> testing. It it checks out, I hope to send a pull request. > >> > >> I've now merged this into my main ppc-for-2.7 branch. I'll be doing > >> some testing, obviously, but I'd certain appreciate any other tests of > >> this branch with the hotplug code. > > > > David, I don't see the unplug patch in your tree, intentional ? > > > > Also I am working on supporting the CPU compat settings with the following > > semantics: > > > > -cpu host,power7 -device host-spapr-cpu-core,compat-cpu=power7 > > I think the old syntax was something like: > > -cpu POWER8,compat=power7 > > So maybe keep that "compat=" prefix for both options? seconded, it should be canonical property syntax "name=value" > > Thomas > >
