On 15/06/2016 10:57, Fam Zheng wrote:
> > + if (!block_job_is_paused(job)) {
>
> I find this check ...
>
> > + return;
> > + }
> > + if (block_job_is_cancelled(job)) {
> > + return;
> > + }
> > +
> > + if (job->driver->pause) {
> > + job->driver->pause(job);
> > + }
> > +
> > + job->paused = true;
>
> ... and this assignment confusing. After reading more, I think we ought to
> rename block_job_is_paused to block_job_should_pause and mark it static, in a
> separate patch.Very good idea! Paolo
