On 14/06/2016 20:17, Stefan Hajnoczi wrote: > v4: > * Add .pause()/.resume() callbacks to really quiesce during > block_job_pause_point() [Paolo] > * Add AioContext change support for backup block job > * Tested drive_mirror + migration and drive_backup + reboot
Also a nice improvement over v3! I think the description of job->busy can be improved further and, more important, I am not sure that mirror_pause is correct. While you are at it, you could annotate mirror_pause and (*pause) as coroutine_fn. But anyway, apart from this Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> Paolo
