On 8 June 2016 at 15:05, Eric Blake <ebl...@redhat.com> wrote: > On 06/08/2016 06:16 AM, Maciej W. Rozycki wrote: >> On Mon, 16 May 2016, Stefan Weil wrote: >> >>> This fixes these warnings from shellcheck: >>> >>> ^-- SC2006: Use $(..) instead of deprecated `..` >>> >>> Signed-off-by: Stefan Weil <s...@weilnetz.de> >>> --- >>> >>> More warnings from shellcheck for configure and other files >>> will be handled by later patches. >> >> Unlike `..` the $(..) Bourne shell construct is not fully portable, some >> implementations do not recognise it. > > All POSIX implementations support it. The only shell that doesn't is > from Solaris /bin/sh, and that pre-dates modern OpenSolaris which has > (finally) modernized their shell. And I don't think we have anyone > actively trying to build qemu for Solaris (we have bug reports for > mingw, BSD, and Mac OS, but I haven't seen anyone complaining about a > failed Solaris build).
We did have somebody some years back, and as I recall what we said was roughly "this is the 21st century and we assume /bin/sh is POSIX". thanks -- PMM
