Am 08.06.2016 um 14:16 schrieb Maciej W. Rozycki: > On Mon, 16 May 2016, Stefan Weil wrote: > >> This fixes these warnings from shellcheck: >> >> ^-- SC2006: Use $(..) instead of deprecated `..` >> >> Signed-off-by: Stefan Weil <s...@weilnetz.de> >> --- >> >> More warnings from shellcheck for configure and other files >> will be handled by later patches. > > Unlike `..` the $(..) Bourne shell construct is not fully portable, some > implementations do not recognise it. Consequently this change potentially > breaks building QEMU on some systems, possibly in a non-obvious way, as > there's no explicit check for the presence this feature and a graceful > failure path included with this patch or the other one AFAICT. We may or > may not care about those systems, but still this is a functional > regression and therefore I think there has to be a good reason for > introducing it.
As the $() construct was already used in QEMU code before this commit (we had a mixture of both styles), I don't expect anything to break which was not broken before. Stefan
signature.asc
Description: OpenPGP digital signature
