On Fri, 2016-04-29 at 15:49 +0100, Peter Maydell wrote: > On 29 April 2016 at 15:31, Stefan Weil <s...@weilnetz.de> wrote: > > > > Is it a bug of the system headers? Or simply a design which > > requires users to be careful when including certain header files? > > > > Both /usr/include/xfs/xfs_fs.h and /usr/include/linux/fs.h define > > the same struct fsxattr, and both definitions are identical. > That sounds like a header bug to me... > > http://oss.sgi.com/archives/xfs/2016-02/msg00324.html > > suggests that (a) the xfsprogs folks are updating their > header to deal with what the kernel header is doing and that > (b) they think the distros ought to be updating both of them > in sync in some way...
yes, even more so that xfsprogs/xfslib will fail to compile using linux-headers-4.5 for the very same reason. However, it looks like distros are not keen on keeping them in sync. the patch is a workaround. Jan > > > > > Of course a good comment would be helpful here, e. g. > > > > # Avoid redefinition of struct fsxattr in xfs/xfs_fs.h. > > # It is already defined in linux/fs.h. > Yes, this is really all I want: a note that some versions of > the kernel headers and the xfs headers clash, so we suppress > the xfs version if the kernel header is providing the struct. > > thanks > -- PMM
signature.asc
Description: This is a digitally signed message part
