On 29 April 2016 at 14:07, Jan Vesely <jano.ves...@gmail.com> wrote:
> Fixes build failure with --enable-xfsctl and
> new linux headers (>=4.5) and older xfsprogs(<4.5):
> In file included from /usr/include/xfs/xfs.h:38:0,
> from
> /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97:
> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
> struct fsxattr {
> ^
> In file included from
> /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:60:0:
> /usr/include/linux/fs.h:155:8: note: originally defined here
> struct fsxattr {
>
> CC: qemu-triv...@nongnu.org
> CC: Markus Armbruster <arm...@redhat.com>
> CC: Peter Maydell <peter.mayd...@linaro.org>
> CC: Stefan Weil <s...@weilnetz.de>
> Signed-off-by: Jan Vesely <jano.ves...@gmail.com>
> ---
> One can argue that the failure only happens for invalid linux-headers,
> xfsprogs combinations, feel free to reject the patch in that case.
>
> This patch relies on functionality introduced in
> 559607ea173 io: add QIOChannelSocket class
>
> configure | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Hi; thanks for this patch. I'm a bit confused by it:
> +if test "$have_fsxattr" = "yes" ; then
> + echo "HAVE_FSXATTR=y" >> $config_host_mak
> +fi
This means we'll build with a HAVE_FSXATTR define set, but
nothing in the tree tries to use that as far as I can tell:
"git grep HAVE_FSXATTR" returns no matches. What am I missing?
thanks
-- PMM
