On 2016/4/23 15:45, Andrew Jones wrote: >>>> @@ -456,14 +460,39 @@ static int load_dtb(hwaddr addr, const struct >>>> arm_boot_info *binfo, >>>> > >> goto fail; >>>> > >> } >>>> > >> >>>> > >> + mem_len = (nb_numa_nodes > 0) ? numa_info[0].node_mem : >>>> > >> binfo->ram_size; >>>> > >> rc = qemu_fdt_setprop_sized_cells(fdt, "/memory", "reg", >>> > > >>> > > So node0's memory node will still be called '/memory' instead of >>> > > '/memory@addr' like the other nodes? Shouldn't we change it too? >>> > > >> > Previously I deleted the /memory node creation codes in virt.c and >> > create here, but that will cause other boards booting fail since >> > load_dtb() is a common function. So to avoid more changes to other >> > files, I just use current way. So is there any way to change the node >> > name after it's created in qemu? > I'm not sure if that's possible, but we could maybe use qemu_fdt_nop_node > to turn /memory into a NOP node, and then add a new one? This would be a good solution, I think. I'll update it using qemu_fdt_nop_node.
Thanks, -- Shannon
