On Fri, Apr 08, 2016 at 04:05:40PM -0600, Eric Blake wrote: > This series is for qemu 2.7, and will probably need some rework > especially since some of it is trying to implement features > that are still marked experimental in upstream NBD. > > Included are some interoperability bug fixes, code cleanups, then > added support both client-side and server-side for: > NBD_FLAG_C_NO_ZEROES > NBD_CMD_WRITE_ZEROES > NBD_CMD_CLOSE
Please hold off with the CLOSE implementation until the discussion on that has finalized. (not commenting on the rest of your series, since that's mostly qemu-specific) -- < ron> I mean, the main *practical* problem with C++, is there's like a dozen people in the world who think they really understand all of its rules, and pretty much all of them are just lying to themselves too. -- #debian-devel, OFTC, 2016-02-12