On 15/03/2016 18:34, Peter Maydell wrote: >> > Since I have your attention, what about getting rid of fprintf-fn.h and >> > moving it into qemu/osdep.h? > Not a lot very osdep-ish about it... If you're going to put it anywhere > then typedefs.h seems more appropriate.
Well, osdep.h is the new qemu-common.h. At least it doesn't include other^Wtoo many other QEMU header files, but it does have a lot of prototypes that are even more out of place than fprintf_function. On the other hand, there are few enough headers that use fprintf-fn.h that it's feasible to just push it down from qemu-common.h. Paolo > (It's in its own file at the moment as part of a previous idea of > cleaning up qemu-common.h by splitting it into separate parts where > necessary so that only the needed parts could be included by the > code that wanted them.)
