On 3 March 2016 at 03:23, Programmingkid <programmingk...@gmail.com> wrote:
> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode
> layout.
>
> Signed-off-by: John Arbuckle <programmingk...@gmail.com>
> +#define LARGEST_KEYCODE 0x7E
You don't need this #define, you can just leave the array
definition as "const int mac_to_qkeycode_map[] = { ..."
and let the compiler determine the size automatically.
> +
> +// Mac to QKeyCode conversion
> +const int macToQKeyCodeMap[LARGEST_KEYCODE + 1] = {
Our coding style says variable names are all lower
case with underscores.
Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
