On 03/03/2016 10:43, Gonglei wrote: > CID 1352419, using g_strdup_printf instead of asprintf. > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > --- > ui/egl-helpers.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c > index 54be44c..2da1930 100644 > --- a/ui/egl-helpers.c > +++ b/ui/egl-helpers.c > @@ -50,18 +50,15 @@ int qemu_egl_rendernode_open(void) > continue; > } > > - r = asprintf(&p, "/dev/dri/%s", e->d_name); > - if (r < 0) { > - return -1; > - } > + p = g_strdup_printf("/dev/dri/%s", e->d_name); > > r = open(p, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK); > if (r < 0) { > - free(p); > + g_free(p); > continue; > } > fd = r; > - free(p); > + g_free(p); > break; > } > >
Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>