Am 13.06.2010 um 15:10 schrieb Jonathan A. Kollasch:
On Sun, Jun 13, 2010 at 02:21:21PM +0200, Andreas Färber wrote:
Am 13.06.2010 um 07:16 schrieb Izumi Tsutsui:
Please email the patch to qemu-devel@nongnu.org via git-send-email.
Isn't the following post enough? What's incomplete on this?
http://lists.nongnu.org/archive/html/qemu-devel/2010-06/
msg00449.html
That is still not a proper git-format-patch patch, it is missing
among others the From: and Subject: lines and, likely, a more
detailled description of what it does and why, for maintainers to be
able to apply it with the git-am tool.
But first it needs to be reviewed and ack'ed by people knowing that
part of the code, and such review is done by inline patches on qemu-
devel mailing list, not by HTTP links to bugtrackers (there are
simply too many patches). The git-send-email tool assures that the
format is not damaged by your favorite mail agent.
Can you imagine how frustrating this is to someone who's just trying
to get a simple bug fix fed upstream?
Yes. Can you imagine what it's like having 3480 unread qemu-devel
messages and an estimated average of 50 patches per day?
I find it quite unreasonable that one should be forced through
this many hoops just to get a trivial patch even considered.
I've been through those hoops myself. I learned Git for this project
and am now voluntarily using it for at least three other projects,
too. It's definitely a good time investment!
In this particular case the reporter apparently went through the hoop
of *deleting* regular git-format-patch output before uploading it and
did not even leave a one-line summary.
I didn't make the rules though, and if Anthony or someone wants to
spend the time of refining such bug patches themselves that's fine
with me. Ryan and I were just trying to help.
Andreas
