On 02/25/2016 12:59 AM, Eric Blake wrote:
> On 02/24/2016 03:11 AM, Changlong Xie wrote:
>> Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible
>> with it.
>>
>> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com>
>> Cc: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
>> Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com>
>> ---
>
>> +++ b/docs/qmp-events.txt
>> @@ -307,6 +307,7 @@ Emitted to report a corruption of a Quorum file.
>>
>> Data:
>>
>> +- "type": Quorum operation type (json-string, optional)
>
> I don't think 'type' needs to be optional, after all. Just always
> output it.
If we output read/write type, old libvirt will ignore the read/write error
events?
Thanks
Wen Congyang
>
>> - "error": Error message (json-string, optional)
>> Only present on failure. This field contains a
>> human-readable
>> error message. There are no semantics other than that
>> the
>> @@ -318,10 +319,17 @@ Data:
>>
>> Example:
>>
>> +Read/Write operation:
>> { "event": "QUORUM_REPORT_BAD",
>> "data": { "node-name": "node0", "sector-num": 345435, "sectors-count":
>> 5 },
>> "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
>
> and this example would then show "type":"read"
>
