-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2016-02-21 09:16, Jan Kiszka wrote: > On 2016-02-17 20:09, David Kiarie wrote: >> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h new file >> mode 100644 index 0000000..4264c19 --- /dev/null +++ >> b/hw/i386/amd_iommu.h > > ... > >> +/* extended feature support */ +#define >> IOMMU_EXT_FEATURES(IOMMU_FEATURE_PREFETCH | IOMMU_FEATURE_PPR | >> \ + IOMMU_FEATURE_NX | IOMMU_FEATURE_IA | IOMMU_FEATURE_GT >> | \ + IOMMU_FEATURE_GA | IOMMU_FEATURE_HE | >> IOMMU_GATS_MODE | \ + IOMMU_HATS_MODE) + +/* capabilities >> header */ +#define IOMMU_CAPAB_FEATURES(IOMMU_CAPAB_FLAT_EXT | \ >> + IOMMU_CAPAB_FLAG_NPCACHE | \ IOMMU_CAPAB_FLAG_IOTLBSUP >> \
Oh, and there is a stray '\' here. >> + | IOMMU_CAPAB_ID_SEC | IOMMU_CAPAB_INIT_TYPE | \ + >> IOMMU_CAPAB_FLAG_HTTUNNEL | IOMMU_CAPAB_EFR_SUP) > > These two do not compile because you misformatted the macros. Must > be > > #define X (Y | Z | ...) > > Jan > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbJcswACgkQitSsb3rl5xRgIACfdNU0T9q5sNfnAqfXSAUSsuuE sMIAoL1duOzpcBkY6OXKxwEpb7uijplA =6zSV -----END PGP SIGNATURE-----