On 02/09/2016 03:16 AM, Denis V. Lunev wrote: > There is a possibility to hit assert qcow2_get_specific_info that
s/hit assert/hit an assert in/ > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The problem is that in the qcow2_invalidate_cache closes and the image > and memsets BDRVQcowState in the middle. Same grammar suggestions as in 1/2. > > The patch moves out processing of bdrv_invalidate_cache_all out of s/moves out/moves/ > coroutine context for postcopy migration to avoid that. This function > is called with the following stack: > process_incoming_migration_co > qemu_loadvm_state > qemu_loadvm_state_main > loadvm_process_command > loadvm_postcopy_handle_run > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > CC: Juan Quintela <quint...@redhat.com> > CC: Amit Shah <amit.s...@redhat.com> > --- > Actually this patch is compile-tested only. I do not know how to start > post-copy migration. Previous patch was tested using 'virst managedsave' Not part of the patch, but s/virst/virsh/ Again, I'll let the migration experts do the actual review. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
