On 02/09/2016 03:16 AM, Denis V. Lunev wrote: When sending a 2-patch series, please include a 0/2 cover letter. The only time a cover letter is not necessary is for a single patch.
> There is a possibility to hit assert qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The problem is that in the qcow2_invalidate_cache closes and the image > and memsets BDRVQcowState in the middle. Grammar; I suggest: The problem is that qcow2_invalidate_cache() closes the image and memset()s BDRVQcowState in the middle. > > The patch moves out processing of bdrv_invalidate_cache_all out of s/moves out/moves/ > coroutine context for standard migration to avoid that. > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > CC: Juan Quintela <quint...@redhat.com> > CC: Amit Shah <amit.s...@redhat.com> > --- > migration/migration.c | 89 > ++++++++++++++++++++++++++++----------------------- > 1 file changed, 49 insertions(+), 40 deletions(-) > I'll leave the migration experts to give a positive review, but I didn't see anything obviously wrong in the refactor. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
