On 01/23/16 17:02, Eduardo Habkost wrote: > This is another attempt to remove old q35 machine code. Now I am > also removing unused compat code to demonstrate the benefit of > throwing away the old code that nobody uses. > > Eduardo Habkost (5): > q35: Remove old machine versions > machine: Remove no_tco field > ich9: Remove enable_tco arguments from init functions > q35: Remove unused q35-acpi-dsdt.aml file > q35: No need to check gigabyte_align > > Makefile | 2 +- > hw/acpi/ich9.c | 8 +-- > hw/i386/pc_q35.c | 176 > +--------------------------------------------- > hw/isa/lpc_ich9.c | 4 +- > include/hw/acpi/ich9.h | 1 - > include/hw/boards.h | 1 - > include/hw/i386/ich9.h | 2 +- > pc-bios/q35-acpi-dsdt.aml | Bin 7344 -> 0 bytes > 8 files changed, 9 insertions(+), 185 deletions(-) > delete mode 100644 pc-bios/q35-acpi-dsdt.aml >
I read / skimmed the earlier discussion: http://thread.gmane.org/gmane.comp.emulators.qemu/356340 http://thread.gmane.org/gmane.comp.emulators.qemu/382574 For patches 1, 2, 3, 5: Reviewed-by: Laszlo Ersek <ler...@redhat.com> For patch 4: How about removing the following two files in addition: - hw/i386/q35-acpi-dsdt.dsl - hw/i386/q35-acpi-dsdt.hex.generated and updating the references in "hw/i386/Makefile.objs"? Thanks Laszlo
