10.12.2015 03:47, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Found thanks to shellcheck! > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > configure | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/configure b/configure > index b55dcdd..6a971a2 100755 > --- a/configure > +++ b/configure > @@ -3994,7 +3994,6 @@ EOF > fi > > # check for smartcard support > -smartcard_cflags="" > if test "$smartcard" != "no"; then > if $pkg_config libcacard; then > libcacard_cflags=$($pkg_config --cflags libcacard) > @@ -4356,7 +4355,6 @@ fi > # If we can't selectively disable warning in the code, disable -Werror so > that > # the build doesn't fail anyway. > > -pragma_disable_unused_but_set=no > cat > $TMPC << EOF > #pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wunused-but-set-variable" > @@ -4791,9 +4789,6 @@ if test "$vnc" = "yes" ; then > echo "VNC JPEG support $vnc_jpeg" > echo "VNC PNG support $vnc_png" > fi > -if test -n "$sparc_cpu"; then > - echo "Target Sparc Arch $sparc_cpu" > -fi > echo "xen support $xen" > if test "$xen" = "yes" ; then > echo "xen ctrl version $xen_ctrl_version" > @@ -5285,7 +5280,6 @@ if test "$qom_cast_debug" = "yes" ; then > fi > if test "$rbd" = "yes" ; then > echo "CONFIG_RBD=m" >> $config_host_mak > - echo "RBD_CFLAGS=$rbd_cflags" >> $config_host_mak
RBD_CFLAGS is used in block/Makefile.objs. We should either drop that variable from there or actually define rbd_cflags in configure. Without either of these, this patch is incomplete. Thanks, /mjt > echo "RBD_LIBS=$rbd_libs" >> $config_host_mak > fi > >
