On 12/22/2015 09:46 AM, Kevin Wolf wrote:
> Version 2 images don't have feature bits, so writing a feature table to
> those images is kind of pointless.

Fortunately, it is also harmless; even the v2 spec allowed for unknown
extension headers.

> 
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
>  block/qcow2.c              | 48 
> ++++++++++++++++++++++++----------------------
>  tests/qemu-iotests/031.out | 12 +-----------
>  tests/qemu-iotests/061.out | 15 ---------------
>  3 files changed, 26 insertions(+), 49 deletions(-)
> 

Reviewed-by: Eric Blake <ebl...@redhat.com>

Did you test that amend'ing an image from v2 to v3 adds the table, and
downgrading from v3 to v2 drops the table?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to