One short remark in addition to Eduardo's review.
Eduardo Habkost <ehabk...@redhat.com> writes:
> On Fri, Dec 18, 2015 at 07:03:49PM +0800, Cao jin wrote:
>> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com>
>> ---
>> hw/pci-host/piix.c | 16 +++++++++-------
>> 1 file changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
>> index 715208b..e3840f0 100644
>> --- a/hw/pci-host/piix.c
>> +++ b/hw/pci-host/piix.c
>> @@ -761,7 +761,7 @@ static const IGDHostInfo igd_host_bridge_infos[] = {
>> {0xa8, 4}, /* SNB: base of GTT stolen memory */
>> };
>>
>> -static int host_pci_config_read(int pos, int len, uint32_t val)
>> +static int host_pci_config_read(int pos, int len, uint32_t val, Error
>> **errp)
>
> You don't need the return value anymore, if you report errors
> through the errp parameter. The function can be void, now.
>
>> {
>> char path[PATH_MAX];
>> int config_fd;
>> @@ -772,15 +772,18 @@ static int host_pci_config_read(int pos, int len,
>> uint32_t val)
>> int ret = 0;
>>
>> if (rc >= size || rc < 0) {
>> + error_setg(errp, "No such device");
>> return -ENODEV;
>> }
>>
>> config_fd = open(path, O_RDWR);
>> if (config_fd < 0) {
>> + error_setg(errp, "No such device");
>> return -ENODEV;
>> }
Can we come up with nicer error messages?
[...]
