Re: [Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64

[Peter Maydell]

On 15 December 2015 at 22:51, Andrew Jones <drjo...@redhat.com> wrote:
> Signed-off-by: Andrew Jones <drjo...@redhat.com>
> ---
>  target-arm/arch_dump.c | 79 
> +++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 71 insertions(+), 8 deletions(-)

> +static int

We don't usually do the 'linebreak before function name' style.

> +aarch64_write_elf64_prfpreg(WriteCoreDumpFunction f, CPUARMState *env,
> +                            int cpuid, DumpState *s)
> +{
> +    struct aarch64_note note;
> +    int ret, i;
> +
> +    aarch64_note_init(&note, s, "CORE", 5, NT_PRFPREG, sizeof(note.vfp));
> +
> +    for (i = 0; i < 64; ++i) {
> +        note.vfp.vregs[i] = cpu_to_dump64(s, float64_val(env->vfp.regs[i]));
> +    }
> +
> +    if (s->dump_info.d_endian == ELFDATA2MSB) {
> +        /* For AArch4 we must always swap the vfp.regs's 2n and 2n+1

"AArch64".

> +         * entries when generating BE notes, because even big endian
> +         * hosts use 2n+1 for the high half.
> +         */

Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>

thanks
-- PMM