Eric Blake <ebl...@redhat.com> writes:
> On 12/17/2015 09:49 AM, Markus Armbruster wrote:
>> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
>> keep coming back. Tracked down with the Coccinelle semantic patch
>> from commit 312fd5f.
>
> Don't forget to rerun this to pick up stragglers exposed by 1/23 :)
Just two:
qemu-nbd.c:574:76:"Shared device number must be greater than 0\n"
qemu-nbd.c:557:61:"socket path must be absolute\n"
>> Signed-off-by: Markus Armbruster <arm...@pond.sub.org>
>> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
>> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
>> Acked-by: Bharata B Rao <bhar...@linux.vnet.ibm.com>
>> Acked-by: Fam Zheng <f...@redhat.com>
>
> If you want to add to the list:
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
>> +++ b/hw/s390x/s390-skeys.c
>> @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss,
>> uint64_t start_gfn,
>> /* Check for uint64 overflow and access beyond end of key data */
>> if (start_gfn + count > skeydev->key_count || start_gfn + count <
>> count) {
>> error_report("Error: Setting storage keys for page beyond the end "
>> - "of memory: gfn=%" PRIx64 " count=%" PRId64 "\n", start_gfn,
>> - count);
>> + "of memory: gfn=%" PRIx64 " count=%" PRId64,
>> + start_gfn, count);
>
> Do we want a separate patch cleaning up 'Error: ' prefixes?
After my Christmas break, in a separate series probably.
