On 12/17/2015 12:00 PM, Markus Armbruster wrote: >>>>> @@ -128,6 +138,7 @@ ErrorClass error_get_class(const Error *err); >>>>> * If @errp is anything else, *@errp must be NULL. >>>>> * The new error's class is ERROR_CLASS_GENERIC_ERROR, and its >>>>> * human-readable error message is made from printf-style @fmt, ... >>>>> + * The resulting message should not contain newlines. >>>> >>>> Should we also discourage trailing punctuation? >>> >>> Yes. How to best phrase it? >> >> Maybe: >> >> The resulting message should be a single phrase, with no newline or >> trailing punctuation. > > What about ending the message with an exclamation mark?
Very few current users do that! An exclamation mark is still trailing punctuation! And I don't like shouting at users! :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature