The code for the pseries machine type is a bit of a hodge podge in terms of error handling. Some parts use the modern error handling APIs, others use old explicit fprintf()s and exit()s.
This patch makes a start on cleaning this up, modernizing the error handling in a number of places to use the current APIs. After this series there are still quite a lot of places using explicit fprintf()s and exit()s, particularly in the device tree handling code. I hope to get to those eventually, but in the meantime, something is better than nothing, right? RESEND: Sorry, forgot to CC the lists the first time around. Apologies to those who get it twice. David Gibson (11): ppc: Cleanup error handling in ppc_set_compat() pseries: Cleanup error handling of spapr_cpu_init() pseries: Clean up hash page table allocation error handling pseries: Clean up error handling in spapr_validate_node_memory() pseries: Cleanup error handling in spapr_vga_init() pseries: Improve error handling in find_unknown_sysbus_device() pseries: Cleanup error handling in spapr_kvm_type() pseries: Clean up error handling in spapr_rtas_register() pseries: Clean up error handling in xics_system_init() pseries: Clean up error handling in ppc_spapr_init() pseries: Clean up error reporting in htab migration functions hw/ppc/spapr.c | 174 ++++++++++++++++++++++++-------------------- hw/ppc/spapr_hcall.c | 10 +-- hw/ppc/spapr_rtas.c | 9 +-- target-ppc/cpu.h | 2 +- target-ppc/translate_init.c | 13 ++-- 5 files changed, 111 insertions(+), 97 deletions(-) -- 2.5.0
