On Fri, Nov 27, 2015 at 11:15:35AM +0100, Paolo Bonzini wrote: > > > On 27/11/2015 03:48, Peter Xu wrote: > > +## > > +# @DUMP_COMPLETED > > +# > > +# Emitted when background dump has completed > > +# > > +# Since: 2.6 > > +## > > +{ 'event': 'DUMP_COMPLETED' , > > + 'data': { 'msg': 'str' } } > > This makes it hard to understand whether there was an error or not. I > suggest using '*error': 'str' instead, and omitting the error if the > dump is successful.
Will adopt it. Thanks! Peter > > Paolo