On Thu, May 27, 2010 at 12:55:49PM +0200, Jes Sorensen wrote: > On 05/27/10 12:44, Michael S. Tsirkin wrote: > > On Thu, May 27, 2010 at 12:22:29PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen <jes.soren...@redhat.com> > >> > >> Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 > >> > >> The format statement expects unsigned long on x86_64, but receives > >> unsigned long long, so gcc exits with an error. > >> > >> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> > > > > I think this part of 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 > > should just be reverted. We have unsigned long, it should be printed > > woith %ll. Casting to uint64_t just so we can print with PRIu64 seems silly. > > That is an option too.
More importantly does this fix the problem for you? > Problem is just that unsigned long is 32 bit on > 32 bit systems and Windows (even for 64 bit) so if we need more flags we > need to be careful with it. > > Cheers, > Jes
